linux-kernel - Re: [PATCH v2 03/30] dt-bindings: phy: qcom,qmp: drop redundant descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7d544eb-4e7f-29a9-815c-693d2369761f@linaro.org>
Date:   Thu, 14 Jul 2022 12:42:11 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Johan Hovold <johan+linaro@...nel.org>,
        Vinod Koul <vkoul@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 03/30] dt-bindings: phy: qcom,qmp: drop redundant
 descriptions

On 14/07/2022 12:00, Johan Hovold wrote:
> On Thu, Jul 14, 2022 at 11:07:21AM +0200, Krzysztof Kozlowski wrote:
>> On 07/07/2022 15:46, Johan Hovold wrote:
>>> Drop the redundant supply and clock descriptions which did not add much
>>> information beyond what can be inferred from the corresponding resource
>>> names.
>>>
>>> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
>>
>>
>> (...)
>>
>>>              - const: ref
>>>              - const: refgen
>>>          resets:
>>> -          items:
>>> -            - description: reset of phy block.
>>> +          maxItems: 1
>>>          reset-names:
>>>            items:
>>>              - const: phy
>>> @@ -376,11 +334,7 @@ allOf:
>>>      then:
>>>        properties:
>>>          clocks:
>>> -          items:
>>> -            - description: Phy aux clock.
>>> -            - description: 19.2 MHz ref clk source.
>>> -            - description: 19.2 MHz ref clk.
>>
>> Here and in other places - I think you loose information, because the
>> frequency is not mentioned in clock name.
> 
> Right, but it is also arguable redundant information for the binding
> (similar for the vdda-pll voltage).

True.

> 
> I can add a comment after the name if you prefer that?

Ah, skip it.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof