[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c84de7ac-5e4f-ce04-bfca-0341f4d6bc1f@linaro.org>
Date: Thu, 14 Jul 2022 12:42:59 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Johan Hovold <johan@...nel.org>
Cc: Johan Hovold <johan+linaro@...nel.org>,
Vinod Koul <vkoul@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Kishon Vijay Abraham I <kishon@...com>,
linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 16/30] dt-bindings: phy: qcom,qmp-ufs: add missing
SM8450 clock
On 14/07/2022 12:07, Johan Hovold wrote:
> On Thu, Jul 14, 2022 at 11:21:52AM +0200, Krzysztof Kozlowski wrote:
>> On 07/07/2022 15:47, Johan Hovold wrote:
>>> Add the missing "qref" clock used by the SM8450 UFS QMP PHY to the
>>> binding.
>>>
>>> Fixes: e04121ba1b08 ("dt-bindings: phy: qcom,qmp: Add SM8450 UFS phy compatible")
>>> Fixes: 07fa917a335e ("arm64: dts: qcom: sm8450: add ufs nodes")
>>
>> The second fixes seems not appropriate here, because you are not fixing
>> a DTS. A fix for DTS would be a fix for that one.
>
> I wanted to highlight the fact the binding wasn't amended when the DTS
> started using the new clock, which it should have. But sure, that would
> have gone in a separate patch. I can replace the second Fixes with a
> Link to the dts submission as a reference instead.
Yes, that or mentioning as "commit xxx ..." in msg would be better.
Best regards,
Krzysztof
Powered by blists - more mailing lists