linux-kernel - Re: [PATCH 1/2] tty: serial: fsl_lpuart: correct the count of break characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f480572d82310c3ed14e476b7cfbe7f2@walle.cc>
Date:   Fri, 15 Jul 2022 08:58:59 +0200
From:   Michael Walle <michael@...le.cc>
To:     Sherry Sun <sherry.sun@....com>
Cc:     gregkh@...uxfoundation.org, jirislaby@...nel.org,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-imx@....com
Subject: Re: [PATCH 1/2] tty: serial: fsl_lpuart: correct the count of break
 characters

Am 2022-07-15 04:59, schrieb Sherry Sun:
> The LPUART can't distinguish between a break signal and a framing 
> error,
> so need to count the break characters if there is a framing error and
> received data is zero instead of the parity error.

Ah, it seems I mixed up the framing and the partiy error. Did you test
the break in the receive path, though?

-michael

> 
> Fixes: 5541a9bacfe5 ("serial: fsl_lpuart: handle break and make sysrq 
> work")
> Signed-off-by: Sherry Sun <sherry.sun@....com>
> ---
>  drivers/tty/serial/fsl_lpuart.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/tty/serial/fsl_lpuart.c 
> b/drivers/tty/serial/fsl_lpuart.c
> index fc7d235a1e27..b6365566a460 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -990,12 +990,12 @@ static void lpuart32_rxint(struct lpuart_port 
> *sport)
> 
>  		if (sr & (UARTSTAT_PE | UARTSTAT_OR | UARTSTAT_FE)) {
>  			if (sr & UARTSTAT_PE) {
> +				sport->port.icount.parity++;
> +			} else if (sr & UARTSTAT_FE) {
>  				if (is_break)
>  					sport->port.icount.brk++;
>  				else
> -					sport->port.icount.parity++;
> -			} else if (sr & UARTSTAT_FE) {
> -				sport->port.icount.frame++;
> +					sport->port.icount.frame++;
>  			}
> 
>  			if (sr & UARTSTAT_OR)
> @@ -1010,12 +1010,12 @@ static void lpuart32_rxint(struct lpuart_port 
> *sport)
>  			sr &= sport->port.read_status_mask;
> 
>  			if (sr & UARTSTAT_PE) {
> +				flg = TTY_PARITY;
> +			} else if (sr & UARTSTAT_FE) {
>  				if (is_break)
>  					flg = TTY_BREAK;
>  				else
> -					flg = TTY_PARITY;
> -			} else if (sr & UARTSTAT_FE) {
> -				flg = TTY_FRAME;
> +					flg = TTY_FRAME;
>  			}
> 
>  			if (sr & UARTSTAT_OR)

-- 
-michael