linux-kernel - Re: [PATCH] ALSA: bcd2000: Fix a UAF bug on the error path of probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a69ax3o1.wl-tiwai@suse.de>
Date:   Fri, 15 Jul 2022 08:58:54 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Zheyu Ma <zheyuma97@...il.com>
Cc:     perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: bcd2000: Fix a UAF bug on the error path of probing

On Fri, 15 Jul 2022 03:05:15 +0200,
Zheyu Ma wrote:
> 
> When the driver fails in snd_card_register() at probe time, it will free
> the 'bcd2k->midi_out_urb' before killing it, which may cause a UAF bug.
> 
> The following log can reveal it:
> 
> [   50.727020] BUG: KASAN: use-after-free in bcd2000_input_complete+0x1f1/0x2e0 [snd_bcd2000]
> [   50.727623] Read of size 8 at addr ffff88810fab0e88 by task swapper/4/0
> [   50.729530] Call Trace:
> [   50.732899]  bcd2000_input_complete+0x1f1/0x2e0 [snd_bcd2000]
> 
> Fix this by adding usb_kill_urb() before usb_free_urb().
> 
> Fixes: b47a22290d58 ("ALSA: MIDI driver for Behringer BCD2000 USB device")
> Signed-off-by: Zheyu Ma <zheyuma97@...il.com>

Thanks, applied.


Takashi