linux-kernel - Re: [net-next PATCH] net: dsa: qca8k: move driver to qca dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62d12418.1c69fb81.90737.3a8e@mx.google.com>
Date:   Fri, 15 Jul 2022 03:57:46 +0200
From:   Christian Marangi <ansuelsmth@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jens Axboe <axboe@...nel.dk>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH] net: dsa: qca8k: move driver to qca dir

On Thu, Jul 14, 2022 at 10:03:54PM -0700, Jakub Kicinski wrote:
> On Wed, 13 Jul 2022 22:53:50 +0200 Christian Marangi wrote:
> > This is a start for the required changes for code
> > split. Greg wasn't so negative about this kind of change
> > so I think we can finally make the move.
> > 
> > Still waiting some comments about the code split.
> > (Can I split qca8k to common function that will be
> > used by ipq4019? (and later propose the actual 
> > ipq4019 driver?))
> 
> Does the split mean that this code will move again?
> If so perhaps better to put this patch in the series 
> that does the split? We're ~2 weeks away from the merge 
> window so we don't want to end up moving the same code
> twice in two consecutive releases.

What to you mean with "will move again"?

The code will be split to qca8k-common.c and qca8k-8xxx.c
And later qca8k-ipq4019.c will be proposed. 

So the files will all stay in qca/ dir.

Or should I just propose the move and the code split in one series?

Tell me what do you prefer.

-- 
	Ansuel