linux-kernel - Re: [PATCH] cpufreq: schedutil: Move max CPU capacity to sugov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gh78z3tw6simaZ5S6dmGvDc-OE6t02N8vQYk-2eoFQgA@mail.gmail.com>
Date:   Fri, 15 Jul 2022 13:44:09 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Lukasz Luba <lukasz.luba@....com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH] cpufreq: schedutil: Move max CPU capacity to sugov_policy

On Fri, Jul 15, 2022 at 10:47 AM Lukasz Luba <lukasz.luba@....com> wrote:
>
> Hi Rafael,
>
> gentle ping.
>
> On 7/11/22 13:42, Lukasz Luba wrote:
> > There is no need to keep the max CPU capacity in the per_cpu instance.
> > Furthermore, there is no need to check and update that variable
> > (sg_cpu->max) everytime in the frequency change request, which is part
> > of hot path. Instead use struct sugov_policy to store that information.
> > Initialize the max CPU capacity during the setup and start callback.
> > We can do that since all CPUs in the same frequency domain have the same
> > max capacity (capacity setup and thermal pressure are based on that).
> >
> > Signed-off-by: Lukasz Luba <lukasz.luba@....com>
> > ---
> >   kernel/sched/cpufreq_schedutil.c | 30 +++++++++++++++---------------
> >   1 file changed, 15 insertions(+), 15 deletions(-)
>
> The patch got Ack from Viresh.
> Could you take it?

Yes, it's there in my queue.  Same for the EM changes.