linux-kernel - Re: [PATCH v6 5/5] io_uring: remove ring quiesce for io_uring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220715154444.GA17123@blackbody.suse.cz>
Date:   Fri, 15 Jul 2022 17:44:44 +0200
From:   Michal Koutný <mkoutny@...e.com>
To:     Usama Arif <usama.arif@...edance.com>
Cc:     io-uring@...r.kernel.org, axboe@...nel.dk, asml.silence@...il.com,
        linux-kernel@...r.kernel.org, fam.zheng@...edance.com
Subject: Re: [PATCH v6 5/5] io_uring: remove ring quiesce for
 io_uring_register

Hello.

On Fri, Feb 04, 2022 at 02:51:17PM +0000, Usama Arif <usama.arif@...edance.com> wrote:
> -	percpu_ref_resurrect(ref);
> [...]
> -		percpu_ref_reinit(&ctx->refs);

It seems to me that this patch could have also changed

--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -1911,7 +1911,7 @@ static __cold struct io_ring_ctx *io_ring_ctx_alloc(struct io_uring_params *p)
        ctx->dummy_ubuf->ubuf = -1UL;

        if (percpu_ref_init(&ctx->refs, io_ring_ctx_ref_free,
-                           PERCPU_REF_ALLOW_REINIT, GFP_KERNEL))
+                           0, GFP_KERNEL))
                goto err;

        ctx->flags = p->flags;

Or are there any plans to still use the reinit/resurrect functionality
of the percpu counter?

Thanks,
Michal