linux-kernel - Re: [PATCH 2/2] mailbox: mvl_mhu: Add support for Marvell Message Handling Unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202207171422.pEzwmwkV-lkp@intel.com>
Date:   Sun, 17 Jul 2022 14:53:56 +0800
From:   kernel test robot <lkp@...el.com>
To:     Wojciech Bartczak <wbartczak@...vell.com>,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, wbartczak@...il.com,
        Jassi Brar <jassisinghbrar@...il.com>,
        Piyush Malgujar <pmalgujar@...vell.com>,
        Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH 2/2] mailbox: mvl_mhu: Add support for Marvell Message
 Handling Unit

Hi Wojciech,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on fujitsu-integration/mailbox-for-next linus/master v5.19-rc6 next-20220715]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Wojciech-Bartczak/Add-support-for-Marvell-MHU-on-CN9x-and-CN10x-SoC/20220714-201522
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20220717/202207171422.pEzwmwkV-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/f04835250e257b46acead49e6233aa6857e159df
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Wojciech-Bartczak/Add-support-for-Marvell-MHU-on-CN9x-and-CN10x-SoC/20220714-201522
        git checkout f04835250e257b46acead49e6233aa6857e159df
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/mailbox/ drivers/of/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/mailbox/mvl_mhu.c: In function 'mhu_pci_setup_irq':
>> drivers/mailbox/mvl_mhu.c:331:29: warning: variable 'np' set but not used [-Wunused-but-set-variable]
     331 |         struct device_node *np;
         |                             ^~


vim +/np +331 drivers/mailbox/mvl_mhu.c

   325	
   326	/* PCI interface in case of LPI based configuration */
   327	static int mhu_pci_setup_irq(struct pci_dev *pdev)
   328	{
   329		struct device *dev;
   330		struct mhu *mhu;
 > 331		struct device_node *np;
   332		int irq, ret, nvec;
   333	
   334		mhu = pci_get_drvdata(pdev);
   335		dev = &pdev->dev;
   336		np = dev->of_node;
   337	
   338		nvec = pci_alloc_irq_vectors(pdev, 0, 3, PCI_IRQ_MSIX);
   339		if (nvec < 0)
   340			return nvec;
   341	
   342		irq = pci_irq_vector(pdev, SCP_TO_AP_INTERRUPT);
   343		if (irq < 0) {
   344			ret = irq;
   345			goto irq_err;
   346		}
   347	
   348		ret = devm_request_threaded_irq(dev, irq, mhu_rx_interrupt,
   349						mhu_rx_interrupt_thread, 0,
   350						"mvl-mhu", mhu);
   351		if (ret)
   352			goto irq_err;
   353	
   354		return 0;
   355	
   356	irq_err:
   357		pci_free_irq_vectors(pdev);
   358	
   359		return ret;
   360	}
   361	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp