linux-kernel - Re: [Intel-gfx] [PATCH v2 24/39] drm/i915: dvo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220718133817.058b8b43@maurocar-mobl2>
Date:   Mon, 18 Jul 2022 13:38:28 +0200
From:   Mauro Carvalho Chehab <mauro.chehab@...ux.intel.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 24/39] drm/i915: dvo_sil164.c: use SPDX
 header

On Fri, 15 Jul 2022 15:16:05 -0700
Joe Perches <joe@...ches.com> wrote:

> On Fri, 2022-07-15 at 17:35 -0400, Rodrigo Vivi wrote:
> > On Wed, Jul 13, 2022 at 09:12:12AM +0100, Mauro Carvalho Chehab wrote:  
> > > This file is licensed with MIT license.	Change its license text
> > > to use SPDX.
> > > 
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab@...nel.org>  
> > 
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@...el.com>  
> 
> Not exactly the MIT license as it's missing "or copyright holders"

Text is not identical, but the license is... see below:

> >   
> > > ---
> > > 
> > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> > > See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/
> > > 
> > >  drivers/gpu/drm/i915/display/dvo_sil164.c | 32 +++++------------------
> > >  1 file changed, 6 insertions(+), 26 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/display/dvo_sil164.c b/drivers/gpu/drm/i915/display/dvo_sil164.c
> > > index 0dfa0a0209ff..12974f7c9dc1 100644
> > > --- a/drivers/gpu/drm/i915/display/dvo_sil164.c
> > > +++ b/drivers/gpu/drm/i915/display/dvo_sil164.c
> > > @@ -1,30 +1,10 @@
> > > -/**************************************************************************
> > > +// SPDX-License-Identifier: MIT
> > >  
> > > -Copyright © 2006 Dave Airlie
> > > -
> > > -All Rights Reserved.
> > > -
> > > -Permission is hereby granted, free of charge, to any person obtaining a
> > > -copy of this software and associated documentation files (the
> > > -"Software"), to deal in the Software without restriction, including
> > > -without limitation the rights to use, copy, modify, merge, publish,
> > > -distribute, sub license, and/or sell copies of the Software, and to
> > > -permit persons to whom the Software is furnished to do so, subject to
> > > -the following conditions:
> > > -
> > > -The above copyright notice and this permission notice (including the
> > > -next paragraph) shall be included in all copies or substantial portions
> > > -of the Software.

The license itself is here. It is standard MIT license. The original
text for the above paragraph is clearer about that:

	"The above copyright notice and this permission notice shall be included in
	 all copies or substantial portions of the Software."

The "next paragraph", mentioned on this variant:

> > > -
> > > -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> > > -OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > > -MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT.
> > > -IN NO EVENT SHALL THE AUTHOR  
> 
> Missing "Authors or copyright holders"

Is actually a disclaimer's note, and not the license itself, informing that
there's no warranties provide by author(s). 

With SPDX, this will point to LICENSES/preferred/MIT with has a paragraph
that fits to the same purpose: it excludes any express or implied
warranties.

Btw, the Kernel itself had this at COPYING by the time this was added
and before SPDX, which was there when this code was added. This is
part of the GPL text:

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

So, I can't see any changes here: with or without this patch, there's
no warranties from the ones that wrote the code - nor for any
copyright holders - as the Kernel as a hole is released under GPL.

Also, LICENSES/preferred/MIT define that MIT license text is:

	MIT License
	
	Copyright (c) <year> <copyright holders>

In this specific case, "Copyright © 2006 Dave Airlie", which is both
the author and the copyright holder that is part of MIT, so the text 
meaning is identical with either "AUTHOR" or "AUTHORS OR COPYRIGHT 
HOLDERS" is used.

So, I can't see any difference from legal standpoint.

Regards,
Mauro