linux-kernel - Re: [PATCH] bpf: Fix typo in comments in verifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220718153548.qvxrgd3ubtlwtuhu@muellerd-fedora-PC2BDTX9>
Date:   Mon, 18 Jul 2022 15:35:48 +0000
From:   Daniel Müller <deso@...teo.net>
To:     Kuee K1r0a <liulin063@...il.com>
Cc:     ast@...nel.org, daniel@...earbox.net, john.fastabend@...il.com,
        andrii@...nel.org, martin.lau@...ux.dev, song@...nel.org,
        yhs@...com, kpsingh@...nel.org, sdf@...gle.com, haoluo@...gle.com,
        jolsa@...nel.org, bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bpf: Fix typo in comments in verifier

On Mon, Jul 18, 2022 at 02:52:31PM +0800, Kuee K1r0a wrote:
> Replace 'then' with 'than'.
> 
> Fixes: f4d7e40a5b71 ("bpf: introduce function calls (verification)")
> Signed-off-by: Kuee K1r0a <liulin063@...il.com>
> ---
>  kernel/bpf/verifier.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 0efbac0fd126..4da1a7c7657a 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -1167,7 +1167,7 @@ static int copy_verifier_state(struct bpf_verifier_state *dst_state,
>  		return -ENOMEM;
>  	dst_state->jmp_history_cnt = src->jmp_history_cnt;
>  
> -	/* if dst has more stack frames then src frame, free them */
> +	/* if dst has more stack frames than src frame, free them */

Should we use plural as well, 'src frames'?

[...]

I believe the patch prefix should indicate which branch the patch targets as
well. E.g., [PATCH bpf-next]. Looks good to me otherwise.

Acked-by: Daniel Müller <deso@...teo.net>