linux-kernel - Re: [PATCH] Makefile: replace headers_install with headers for kselftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAQ4iMBwu4bOmmOrMudNH49ruz-7AK_H3-ceTixd=G+brQ@mail.gmail.com>
Date:   Wed, 20 Jul 2022 00:06:05 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Guillaume Tucker <guillaume.tucker@...labora.com>
Cc:     Shuah Khan <skhan@...uxfoundation.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Shuah Khan <shuah@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Anders Roxell <anders.roxell@...aro.org>,
        Tim Bird <Tim.Bird@...y.com>, kernel@...labora.com,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH] Makefile: replace headers_install with headers for kselftest

On Tue, Jul 19, 2022 at 9:37 PM Guillaume Tucker
<guillaume.tucker@...labora.com> wrote:
>
> On 14/07/2022 22:45, Shuah Khan wrote:
> > On 7/13/22 12:33 AM, Guillaume Tucker wrote:
> >> Replace headers_install with headers as kselftest uses the header
> >> files from within the kernel tree rather than from a system-wide
> >> installation.
> >>
> >> We can still run this directly:
> >>
> >>    $ make O=build kselftest-all
> >>
> >> and when building from the selftests directory:
> >>
> >>    $ make O=build headers
> >>    $ make O=build -C tools/testing/selftests all
> >>
> >> Signed-off-by: Guillaume Tucker <guillaume.tucker@...labora.com>
> >> Reported-by: Masahiro Yamada <masahiroy@...nel.org>
> >> ---
> >>   Makefile | 4 ++--
> >>   1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/Makefile b/Makefile
> >> index fb2f3bb53a6b..5c934d16664c 100644
> >> --- a/Makefile
> >> +++ b/Makefile
> >> @@ -1347,10 +1347,10 @@ tools/%: FORCE
> >>   # Kernel selftest
> >>     PHONY += kselftest
> >> -kselftest: headers_install
> >> +kselftest: headers
> >>       $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests
> >>   -kselftest-%: headers_install FORCE
> >> +kselftest-%: headers FORCE
> >>       $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests $*
> >>     PHONY += kselftest-merge
> >>
> >
> > Thank you for taking care of this. This will go through kbuild?
>
> You're welcome.
>
> Masahiro-san,
>
> A you OK with applying this in the kbuild tree ahead of the
> upcoming merge window?


No.

This is a fix-up patch on top of the previous one [1],
which  was applied to the kselftest tree.

This cannot apply to the kbuild tree.

[1]: https://lore.kernel.org/linux-kbuild/168ede35-12e0-c535-9d94-23b65a1beb28@collabora.com/T/#mb8ec7004f7c9b89fbb50c19022760e19701af7f6






> Best wishes,
> Guillaume
>
> > Acked-by: Shuah Khan <skhan@...uxfoundation.org>
> >
> > thanks,
> > -- Shuah
> >



-- 
Best Regards
Masahiro Yamada