linux-kernel - Re: [PATCH] Makefile: replace headers_install with headers for kselftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8fc9d169-78ff-0fe4-67c0-784097861f12@collabora.com>
Date:   Tue, 19 Jul 2022 14:37:15 +0200
From:   Guillaume Tucker <guillaume.tucker@...labora.com>
To:     Shuah Khan <skhan@...uxfoundation.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Shuah Khan <shuah@...nel.org>,
        Kees Cook <keescook@...omium.org>
Cc:     Anders Roxell <anders.roxell@...aro.org>, Tim.Bird@...y.com,
        kernel@...labora.com, linux-kbuild@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] Makefile: replace headers_install with headers for
 kselftest

On 14/07/2022 22:45, Shuah Khan wrote:
> On 7/13/22 12:33 AM, Guillaume Tucker wrote:
>> Replace headers_install with headers as kselftest uses the header
>> files from within the kernel tree rather than from a system-wide
>> installation.
>>
>> We can still run this directly:
>>
>>    $ make O=build kselftest-all
>>
>> and when building from the selftests directory:
>>
>>    $ make O=build headers
>>    $ make O=build -C tools/testing/selftests all
>>
>> Signed-off-by: Guillaume Tucker <guillaume.tucker@...labora.com>
>> Reported-by: Masahiro Yamada <masahiroy@...nel.org>
>> ---
>>   Makefile | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index fb2f3bb53a6b..5c934d16664c 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1347,10 +1347,10 @@ tools/%: FORCE
>>   # Kernel selftest
>>     PHONY += kselftest
>> -kselftest: headers_install
>> +kselftest: headers
>>       $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests
>>   -kselftest-%: headers_install FORCE
>> +kselftest-%: headers FORCE
>>       $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests $*
>>     PHONY += kselftest-merge
>>
> 
> Thank you for taking care of this. This will go through kbuild?

You're welcome.

Masahiro-san,

A you OK with applying this in the kbuild tree ahead of the
upcoming merge window?

Best wishes,
Guillaume
 
> Acked-by: Shuah Khan <skhan@...uxfoundation.org>
> 
> thanks,
> -- Shuah
>