linux-kernel - Re: [PATCH 07/35] perf script: Add --dump-unsorted-raw-trace option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fXtV=p_N=hQPUXzw6TV4st=qpEp7U8H-eDZJgr2BoiVeQ@mail.gmail.com>
Date:   Tue, 19 Jul 2022 10:11:49 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH 07/35] perf script: Add --dump-unsorted-raw-trace option

On Mon, Jul 11, 2022 at 2:33 AM Adrian Hunter <adrian.hunter@...el.com> wrote:
>
> When reviewing the results of perf inject, it is useful to be able to see
> the events in the order they appear in the file.
>
> So add --dump-unsorted-raw-trace option to do an unsorted dump.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>

Acked-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/Documentation/perf-script.txt | 3 +++
>  tools/perf/builtin-script.c              | 8 ++++++++
>  2 files changed, 11 insertions(+)
>
> diff --git a/tools/perf/Documentation/perf-script.txt b/tools/perf/Documentation/perf-script.txt
> index 1a557ff8f210..e250ff5566cf 100644
> --- a/tools/perf/Documentation/perf-script.txt
> +++ b/tools/perf/Documentation/perf-script.txt
> @@ -79,6 +79,9 @@ OPTIONS
>  --dump-raw-trace=::
>          Display verbose dump of the trace data.
>
> +--dump-unsorted-raw-trace=::
> +        Same as --dump-raw-trace but not sorted in time order.
> +
>  -L::
>  --Latency=::
>          Show latency attributes (irqs/preemption disabled, etc).
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 7cf21ab16f4f..4b00a50faf00 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -3746,6 +3746,7 @@ int cmd_script(int argc, const char **argv)
>         bool header = false;
>         bool header_only = false;
>         bool script_started = false;
> +       bool unsorted_dump = false;
>         char *rec_script_path = NULL;
>         char *rep_script_path = NULL;
>         struct perf_session *session;
> @@ -3794,6 +3795,8 @@ int cmd_script(int argc, const char **argv)
>         const struct option options[] = {
>         OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,
>                     "dump raw trace in ASCII"),
> +       OPT_BOOLEAN(0, "dump-unsorted-raw-trace", &unsorted_dump,
> +                   "dump unsorted raw trace in ASCII"),
>         OPT_INCR('v', "verbose", &verbose,
>                  "be more verbose (show symbol address, etc)"),
>         OPT_BOOLEAN('L', "Latency", &latency_format,
> @@ -3956,6 +3959,11 @@ int cmd_script(int argc, const char **argv)
>         data.path  = input_name;
>         data.force = symbol_conf.force;
>
> +       if (unsorted_dump) {
> +               dump_trace = true;
> +               script.tool.ordered_events = false;
> +       }
> +
>         if (symbol__validate_sym_arguments())
>                 return -1;
>
> --
> 2.25.1
>