linux-kernel - Re: [PATCH v2] platform/chrome: cros_typec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YtZSuI5X96w83S6j@kroah.com>
Date:   Tue, 19 Jul 2022 08:44:08 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Prashant Malani <pmalani@...omium.org>
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        chrome-platform@...ts.linux.dev, bleung@...omium.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2] platform/chrome: cros_typec_switch: Add ACPI Kconfig
 dep

On Mon, Jul 18, 2022 at 09:27:55PM +0000, Prashant Malani wrote:
> Add the ACPI Kconfig dependency that was missed during the initial
> driver submission. Fixes the following compiler errors:
> 
> drivers/platform/chrome/cros_typec_switch.c:93:9: error: call to
> undeclared function 'acpi_evaluate_integer'; ISO C99 and later do not
> support implicit function declarations
>  [-Wimplicit-function-declaration]
>    ret = acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index);
> 
> drivers/platform/chrome/cros_typec_switch.c:93:35: error: incomplete
> definition of type 'struct acpi_device'
>    ret = acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index);
> 
> Fixes: e54369058f3d ("platform/chrome: cros_typec_switch: Add switch driver")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Prashant Malani <pmalani@...omium.org>
> ---
> 
> Changes since v1:
> - Correct the malformed Reported-by tag. No functional changes.
> (Apologies for the quick respin.)

I already have v1 in my tree, so this isn't going to work, sorry.

greg k-h