linux-kernel - Re: build failure of next-20220718 due to 'imx6_pcie_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a31EeUBRs62=nR2Uj-d9dX2Mcc+fO=wE1nLYh+U1aNFfg@mail.gmail.com>
Date:   Tue, 19 Jul 2022 09:52:30 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "Sudip Mukherjee (Codethink)" <sudipm.mukherjee@...il.com>,
        Richard Zhu <hongxing.zhu@....com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        linux-pci <linux-pci@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: build failure of next-20220718 due to 'imx6_pcie_host_exit'
 defined but not used

On Mon, Jul 18, 2022 at 6:14 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
> On Mon, Jul 18, 2022 at 02:42:16PM +0200, Arnd Bergmann wrote:
>
> Might be simpler, but wow, it's hard to keep up with all the
> permutations of sleep ops ;)
>
> Unfortunately 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros,
> deprecate old ones"), which added NOIRQ_SYSTEM_SLEEP_PM_OPS, didn't
> add any hints near SET_NOIRQ_SYSTEM_SLEEP_PM_OPS.
>
> We have several PCI controller drivers that use the "#ifdef
> CONFIG_PM_SLEEP" and SET_NOIRQ_SYSTEM_SLEEP_PM_OPS pattern or the
> "__maybe_unused" + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS pattern.  I guess we
> need to look at all of them and figure out the best practice.

Yes, this is a larger effort. It's been under discussion for many years until we
could agree on a nicer way to handle this and avoid both the #ifdef  and the
__maybe_unused annotations. There are hundreds of drivers using the older
patterns, and I think there is an effort to address them one subsystem
at a time,
whenever someone finds the time.

       Arnd