linux-kernel - Re: [PATCH 1/3] ARM: dts: lan966x: Add gpio-restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e0b7137-08d1-fef2-86b5-a48419dd2101@microchip.com>
Date:   Tue, 19 Jul 2022 07:52:29 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <Horatiu.Vultur@...rochip.com>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <Nicolas.Ferre@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
        <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH 1/3] ARM: dts: lan966x: Add gpio-restart

On 19.07.2022 00:29, Horatiu Vultur wrote:
> The pcb8291 can be rebooted by toggling the GPIO 56. Therefore enable
> this in DT.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> ---
>  arch/arm/boot/dts/lan966x-pcb8291.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> index d56d2054c38d..02fbf7371a8d 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> @@ -16,6 +16,12 @@ chosen {
>  	aliases {
>  		serial0 = &usart3;
>  	};
> +
> +	gpio-restart {
> +		compatible = "gpio-restart";
> +		gpios = <&gpio 56 GPIO_ACTIVE_LOW>;

Could you, please, add also pinctrl-names, pinctrl-0 for this gpio?

> +		priority = <200>;
> +	};
>  };
>  
>  &gpio {