linux-kernel - Re: [PATCH 2/3] ARM: dts: lan966x: Disable can0 on pcb8291

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <530ef4f3-26ce-5a90-f2f7-d6163124bfec@microchip.com>
Date:   Tue, 19 Jul 2022 07:55:56 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <Horatiu.Vultur@...rochip.com>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <Nicolas.Ferre@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
        <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH 2/3] ARM: dts: lan966x: Disable can0 on pcb8291

On 19.07.2022 00:29, Horatiu Vultur wrote:
> On pcb8291, can0 and the network driver share some of the GPIOs so only
> 1 device can be active. Therefore disable can0 as we want to enable the
> network driver.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> ---
>  arch/arm/boot/dts/lan966x-pcb8291.dts | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> index 02fbf7371a8d..2cb532aa33f0 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> @@ -30,18 +30,6 @@ fc3_b_pins: fc3-b-pins {
>  		pins = "GPIO_52", "GPIO_53";
>  		function = "fc3_b";
>  	};
> -
> -	can0_b_pins:  can0-b-pins {
> -		/* RX, TX */
> -		pins = "GPIO_35", "GPIO_36";
> -		function = "can0_b";
> -	};
> -};
> -
> -&can0 {
> -	pinctrl-0 = <&can0_b_pins>;
> -	pinctrl-names = "default";
> -	status = "okay";

You can just delete the status line here or change it to "disabled" and
leave the rest for reference. For evaluation one could just enable it here
afterwards. On the other AT91 specific boards we are using status =
"disabled"; and a short comment after like this:

	status = "disabled"; /* Conflict with gmac0. */

>  };
>  
>  &flx3 {