linux-kernel - Re: [PATCH 3/4] dt-bindings: panel: Add LG SW43408 MIPI-DSI panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YtZj1yV3blLOJH62@ravnborg.org>
Date:   Tue, 19 Jul 2022 09:57:11 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Caleb Connolly <caleb@...nolly.tech>
Cc:     devicetree@...r.kernel.org, David Airlie <airlied@...ux.ie>,
        linux-arm-msm@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Vinod Koul <vkoul@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        dri-devel@...ts.freedesktop.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        phone-devel@...r.kernel.org,
        Sumit Semwal <sumit.semwal@...aro.org>,
        linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 3/4] dt-bindings: panel: Add LG SW43408 MIPI-DSI panel

Hi Caleb,

On Tue, Jul 19, 2022 at 08:10:18AM +0200, Sam Ravnborg wrote:
> Hi Caleb,
> 
> On Mon, Jul 18, 2022 at 10:30:50PM +0100, Caleb Connolly wrote:
> > From: Sumit Semwal <sumit.semwal@...aro.org>
> > 
> > LG SW43408 is 1080x2160, 4-lane MIPI-DSI panel.
> A few things to improve to this binding.
> 
> 	Sam
> > 
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> > Signed-off-by: Sumit Semwal <sumit.semwal@...aro.org>
> > [caleb: convert to yaml]
> > Signed-off-by: Caleb Connolly <caleb@...nolly.tech>
> > ---
> >  .../bindings/display/panel/lg,43408.yaml      | 41 +++++++++++++++++++
> >  .../display/panel/panel-simple-dsi.yaml       |  2 +
> >  2 files changed, 43 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/lg,43408.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/display/panel/lg,43408.yaml b/Documentation/devicetree/bindings/display/panel/lg,43408.yaml
> > new file mode 100644
> > index 000000000000..0529a3aa2692
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/lg,43408.yaml
> > @@ -0,0 +1,41 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: LG SW43408 1080x2160 DSI panel
> > +
> > +maintainers:
> > +  - Caleb Connolly <caleb@...nolly.tech>
> > +
> > +description: |
> > +  This panel is used on the Pixel 3, it is a 60hz OLED panel which
> > +  required DSC (Display Stream Compression) and has rounded corners.
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - const: lg,sw43408
> > +
> > +  vddi-supply: true
> > +  vpnl-supply: true
> > +  reset-gpios: true
> > +
> > +  backlight: false
> > +  power-supply: false
> No need to say anything is false, this is covered by the statement below.
> Also, the driver uses backlight, so it should be true?
The driver do not use backlight from the DT so disregard the last
comment.

	Sam