linux-kernel - Re: [PATCH net-next 1/2] mlxsw: use netif_is_any_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YtmU//3wdPm28LPl@shredder>
Date:   Thu, 21 Jul 2022 21:03:43 +0300
From:   Ido Schimmel <idosch@...dia.com>
To:     Juhee Kang <claudiajkang@...il.com>
Cc:     netdev@...r.kernel.org, tchornyi@...vell.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        petrm@...dia.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] mlxsw: use netif_is_any_bridge_port()
 instead of open code

On Thu, Jul 21, 2022 at 07:26:47PM +0900, Juhee Kang wrote:
> The open code which is netif_is_bridge_port() || netif_is_ovs_port() is
> defined as a new helper function on netdev.h like netif_is_any_bridge_port
> that can check both IFF flags in 1 go. So use netif_is_any_bridge_port()
> function instead of open code. This patch doesn't change logic.
> 
> Signed-off-by: Juhee Kang <claudiajkang@...il.com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>