linux-kernel - Re: [RESEND PATCH 2/9] dt-bindings: arm64: bcmbca: Update BCM4908 description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0fa14ba8c4782bde5148d389e2f2a37@milecki.pl>
Date:   Thu, 21 Jul 2022 08:11:38 +0200
From:   Rafał Miłecki <rafal@...ecki.pl>
To:     William Zhang <william.zhang@...adcom.com>
Cc:     Linux ARM List <linux-arm-kernel@...ts.infradead.org>,
        joel.peshkin@...adcom.com, dan.beygelman@...adcom.com,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Anand Gore <anand.gore@...adcom.com>,
        Kursad Oney <kursad.oney@...adcom.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH 2/9] dt-bindings: arm64: bcmbca: Update BCM4908
 description

On 2022-07-21 02:06, William Zhang wrote:
> Append "brcm,bcmbca" to BCM4908 chip family compatible strings. Add
> generic 4908 board entry.
> 
> Signed-off-by: William Zhang <william.zhang@...adcom.com>

Acked-by: Rafał Miłecki <rafal@...ecki.pl>

(with one minor comment below)

> ---
> 
>  Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> index 6a64afa95918..4494a2c58c7f 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> @@ -36,18 +36,22 @@ properties:
>                - tplink,archer-c2300-v1
>            - const: brcm,bcm4906
>            - const: brcm,bcm4908
> +          - const: brcm,bcmbca
> 
>        - description: BCM4908 based boards
>          items:
>            - enum:
>                - asus,gt-ac5300
>                - netgear,raxe500
> +              - brcm,bcm94908

I think it would be nice to keep enum entries sorted


>            - const: brcm,bcm4908
> +          - const: brcm,bcmbca
> 
>        - description: BCM49408 based boards
>          items:
>            - const: brcm,bcm49408
>            - const: brcm,bcm4908
> +          - const: brcm,bcmbca
> 
>        - description: BCM4912 based boards
>          items: