linux-kernel - Re: [RESEND PATCH 5/9] arm64: dts: Add BCM4908 generic board dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Jul 2022 08:45:54 +0200
From:   Rafał Miłecki <rafal@...ecki.pl>
To:     William Zhang <william.zhang@...adcom.com>
Cc:     Linux ARM List <linux-arm-kernel@...ts.infradead.org>,
        joel.peshkin@...adcom.com, dan.beygelman@...adcom.com,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Anand Gore <anand.gore@...adcom.com>,
        Kursad Oney <kursad.oney@...adcom.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH 5/9] arm64: dts: Add BCM4908 generic board dts

On 2022-07-21 02:07, William Zhang wrote:
> Add generic bcm94908.dts file.
> 
> Signed-off-by: William Zhang <william.zhang@...adcom.com>
> ---
> 
>  arch/arm64/boot/dts/broadcom/bcmbca/Makefile  |  1 +
>  .../boot/dts/broadcom/bcmbca/bcm94908.dts     | 30 +++++++++++++++++++
>  2 files changed, 31 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/broadcom/bcmbca/bcm94908.dts
> 
> diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/Makefile
> b/arch/arm64/boot/dts/broadcom/bcmbca/Makefile
> index d30fa75f0611..27741b71ba9e 100644
> --- a/arch/arm64/boot/dts/broadcom/bcmbca/Makefile
> +++ b/arch/arm64/boot/dts/broadcom/bcmbca/Makefile
> @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_BCMBCA) += \
>  				bcm4906-tplink-archer-c2300-v1.dtb \
>  				bcm4908-asus-gt-ac5300.dtb \
>  				bcm4908-netgear-raxe500.dtb \
> +				bcm94908.dtb \
>  				bcm4912-asus-gt-ax6000.dtb \
>  				bcm94912.dtb \
>  				bcm963158.dtb \

AFAIU bcm94908 is a reference board name. I think I see some
inconsistency in naming Broadcom's reference boards DTS files.

If you take a look at in-kernel DTS files:
find ./arch/arm*/boot/dts/ -name "*.dts"
99% of them are prefixed with family/SoC name. I did the same for
bcm4908 (and Northstar) boards. So it's
<soc>-<manufacturer>-<model>.dts
e.g.
bcm4908-asus-gt-ac5300.dts

To match that I *think* you should actually call your file:
bcm4908-bcm94908 (or bcm4908-94908 depending on actual board name)

First of all: am I correct here?

Secondly: could you do that? I know many DTS files named ignoring SoC/
family prefix. Still maybe we could change it as some (this) point?