[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Ytj/27UCySaronBO@unreal>
Date: Thu, 21 Jul 2022 10:27:23 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Cheng Xu <chengyou@...ux.alibaba.com>,
Jason Gunthorpe <jgg@...pe.ca>,
Kai Shen <kaishen@...ux.alibaba.com>,
Dan Carpenter <dan.carpenter@...cle.com>,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
linux-rdma@...r.kernel.org
Subject: Re: [PATCH 1/2] RDMA/erdma: Use the bitmap API to allocate bitmaps
On Tue, Jul 19, 2022 at 05:36:36PM +0200, Christophe JAILLET wrote:
> Le 19/07/2022 à 15:01, Dan Carpenter a écrit :
> > On Tue, Jul 19, 2022 at 09:54:34AM -0300, Jason Gunthorpe wrote:
> > > On Tue, Jul 12, 2022 at 12:01:10PM +0300, Dan Carpenter wrote:
> > >
> > > > Best not to use any auto-formatting tools. They are all bad.
> > >
> > > Have you tried clang-format? I wouldn't call it bad..
> >
> > I prefered Christophe's formatting to clang's. ;)
> >
> > regards,
> > dan carpenter
> >
> >
>
> Hi,
>
> checkpatch.pl only gives hints and should not blindly be taken as THE
> reference, but:
>
> ./scripts/checkpatch.pl -f --strict
> drivers/infiniband/hw/erdma/erdma_cmdq.c
>
> gives:
> CHECK: Lines should not end with a '('
> #81: FILE: drivers/infiniband/hw/erdma/erdma_cmdq.c:81:
> + cmdq->comp_wait_bitmap = devm_bitmap_zalloc(
>
> total: 0 errors, 0 warnings, 1 checks, 493 lines checked
>
> (some other files in the same directory also have some checkpatch
> warning/error)
>
>
>
> Don't know if it may be an issue for maintainers.
We don't run with --strict. It is indeed very subjective.
Thanks
>
> CJ
Powered by blists - more mailing lists