linux-kernel - Re: [PATCH] xfs: Fix comment typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d8dfa68b-00d8-9853-e2ba-57c2bb54c05a@redhat.com>
Date:   Fri, 22 Jul 2022 15:20:10 -0500
From:   Eric Sandeen <sandeen@...hat.com>
To:     Xin Gao <gaoxin@...rlc.com>, djwong@...nel.org
Cc:     dchinner@...hat.com, chandan.babu@...cle.com,
        linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: Fix comment typo

On 7/22/22 2:36 PM, Xin Gao wrote:
> The double `for' is duplicated in line 3788, remove one.
> 
> Signed-off-by: Xin Gao <gaoxin@...rlc.com>
> ---
>  fs/xfs/libxfs/xfs_bmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index 6833110d1bd4..6f6d87ba29a3 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -3785,7 +3785,7 @@ xfs_bmapi_trim_map(
>  		mval->br_startblock = got->br_startblock +
>  					(*bno - got->br_startoff);
>  	/*
> -	 * Return the minimum of what we got and what we asked for for
> +	 * Return the minimum of what we got and what we asked for
>  	 * the length.  We can use the len variable here because it is
>  	 * modified below and we could have been there before coming
>  	 * here if the first part of the allocation didn't overlap what

NAK.

The comment is correct.