linux-kernel - Re: [PATCH] drm/bridge: ti-sn65dsi86: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f5f6fbb-5a6c-3bc3-20f7-1a97854434b0@redhat.com>
Date:   Sat, 23 Jul 2022 01:41:01 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Andrzej Hajda <andrzej.hajda@...el.com>,
        Jonas Karlman <jonas@...boo.se>,
        David Airlie <airlied@...ux.ie>,
        Robert Foss <robert.foss@...aro.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Erico Nunes <ernunes@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Enric Balletbo i Serra <eballetbo@...hat.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: Use dev_err_probe() to avoid
 polluting the log

On 7/22/22 15:35, Doug Anderson wrote:
> Hi,
> 
> On Fri, Jul 22, 2022 at 12:48 AM Javier Martinez Canillas
> <javierm@...hat.com> wrote:
>>
>> If devm_drm_of_get_bridge() can't find the connected bridge, it returns an
>> ERR_PTR(-EPROBE_DEFER) to indicate that the probe should be deferred.
>>
>> But this path also prints an error message, which pollutes the kernel log
>> since is printed on every probe deferral, i.e:
>>
>>   $ dmesg | grep "failed to create panel bridge" | wc -l
>>   38
>>
>> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
>> ---
>>
>>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> 
> If someone else doesn't beat me to it, I'll apply next week sometime.
> 

I've pushed this to drm-misc (drm-misc-next). Thanks all!

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat