linux-kernel - Re: [PATCH] drm/bridge: ti-sn65dsi86: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=WR3UP4XMch5z8Hz8GzWRg5cCsK6FVwgoo=HHDnpTwz+g@mail.gmail.com>
Date:   Fri, 22 Jul 2022 06:35:55 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Javier Martinez Canillas <javierm@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Erico Nunes <ernunes@...hat.com>,
        Enric Balletbo i Serra <eballetbo@...hat.com>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Jonas Karlman <jonas@...boo.se>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Robert Foss <robert.foss@...aro.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: Use dev_err_probe() to avoid
 polluting the log

Hi,

On Fri, Jul 22, 2022 at 12:48 AM Javier Martinez Canillas
<javierm@...hat.com> wrote:
>
> If devm_drm_of_get_bridge() can't find the connected bridge, it returns an
> ERR_PTR(-EPROBE_DEFER) to indicate that the probe should be deferred.
>
> But this path also prints an error message, which pollutes the kernel log
> since is printed on every probe deferral, i.e:
>
>   $ dmesg | grep "failed to create panel bridge" | wc -l
>   38
>
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
> ---
>
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: Douglas Anderson <dianders@...omium.org>

If someone else doesn't beat me to it, I'll apply next week sometime.