linux-kernel - Re: [PATCH] gpio: gpio-xilinx: Fix integer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Jul 2022 09:17:32 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Srinivas Neeli <srinivas.neeli@...inx.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Michal Simek <michal.simek@...inx.com>,
        neelisrinivas18@...il.com, shubhrajyoti.datta@...inx.com,
        srinivas.neeli@....com, sgoud@...inx.com,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        git@...inx.com
Subject: Re: [PATCH] gpio: gpio-xilinx: Fix integer overflow

On Thu, Jul 21, 2022 at 9:39 AM Srinivas Neeli
<srinivas.neeli@...inx.com> wrote:
>
> Current implementation is not able to configure more than 32 pins
> due to incorrect data type. So type casting with unsigned long
> to avoid it.
>
> Fixes: 02b3f84d9080 ("xilinx: Switch to use bitmap APIs")
> Signed-off-by: Srinivas Neeli <srinivas.neeli@...inx.com>
> ---
>  drivers/gpio/gpio-xilinx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index b6d3a57e27ed..7f8e2fed2988 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -99,7 +99,7 @@ static inline void xgpio_set_value32(unsigned long *map, int bit, u32 v)
>         const unsigned long offset = (bit % BITS_PER_LONG) & BIT(5);
>
>         map[index] &= ~(0xFFFFFFFFul << offset);
> -       map[index] |= v << offset;
> +       map[index] |= (unsigned long)v << offset;
>  }
>
>  static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch)
> --
> 2.17.1
>

Applied, thanks!

Bart