linux-kernel - Re: [PATCH] gpio: gpio-xilinx: Fix integer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Jul 2022 22:04:47 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Srinivas Neeli <srinivas.neeli@...inx.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Michal Simek <michal.simek@...inx.com>,
        neelisrinivas18@...il.com,
        Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
        srinivas.neeli@....com, Srinivas Goud <sgoud@...inx.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        git <git@...inx.com>
Subject: Re: [PATCH] gpio: gpio-xilinx: Fix integer overflow

On Fri, Jul 22, 2022 at 9:19 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> On Thu, Jul 21, 2022 at 9:39 AM Srinivas Neeli
> <srinivas.neeli@...inx.com> wrote:
> >
> > Current implementation is not able to configure more than 32 pins
> > due to incorrect data type. So type casting with unsigned long
> > to avoid it.

> > Fixes: 02b3f84d9080 ("xilinx: Switch to use bitmap APIs")

It doesn't fix anything,  I already reject one such "fix" during
development of this patch. Thanks!

...

> > @@ -99,7 +99,7 @@ static inline void xgpio_set_value32(unsigned long *map, int bit, u32 v)
> >         const unsigned long offset = (bit % BITS_PER_LONG) & BIT(5);
> >
> >         map[index] &= ~(0xFFFFFFFFul << offset);
> > -       map[index] |= v << offset;
> > +       map[index] |= (unsigned long)v << offset;
> >  }

> Applied, thanks!

False positive.

-- 
With Best Regards,
Andy Shevchenko