linux-kernel - Re: [PATCH v5 9/9] drm: selftest: convert drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220722162529.wy4ox7pyjhno66lz@macragge.hardline.pl>
Date:   Fri, 22 Jul 2022 18:25:29 +0200
From:   Michał Winiarski <michal@...dline.pl>
To:     Maíra Canal <maira.canal@....br>
Cc:     Matthew Auld <matthew.william.auld@...il.com>,
        Arthur Grillo <arthur.grillo@....br>,
        siqueirajordao@...eup.net, David Airlie <airlied@...ux.ie>,
        Daniel Latypov <dlatypov@...gle.com>,
        brendanhiggins@...gle.com,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        linux-kselftest@...r.kernel.org, n@...aprado.net,
        Isabella Basso <isabbasso@...eup.net>, andrealmeid@...eup.net,
        magalilemes00@...il.com,
        Javier Martinez Canillas <javierm@...hat.com>,
        kunit-dev@...glegroups.com, mwen@...lia.com,
        David Gow <davidgow@...gle.com>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Michał Winiarski <michal.winiarski@...el.com>,
        tales.aparecida@...il.com,
        kernel list <linux-kernel@...r.kernel.org>,
        leandro.ribeiro@...labora.com,
        Thomas Zimmermann <tzimmermann@...e.de>,
        José Expósito <jose.exposito89@...il.com>
Subject: Re: [PATCH v5 9/9] drm: selftest: convert drm_mm selftest to KUnit

On Fri, Jul 22, 2022 at 08:04:51AM -0300, Maíra Canal wrote:
> On 7/22/22 07:35, Matthew Auld wrote:
> > On Fri, 8 Jul 2022 at 21:32, Maíra Canal <maira.canal@....br> wrote:
> >>
> >> From: Arthur Grillo <arthur.grillo@....br>
> >>
> >> Considering the current adoption of the KUnit framework, convert the
> >> DRM mm selftest to the KUnit API.
> > 
> > Is there a plan to convert the corresponding selftest IGT that was
> > responsible for running this (also drm_buddy) to somehow work with
> > kunit? Previously these IGTs were always triggered as part of
> > intel-gfx CI, but it looks like they are no longer run[1].
> > 
> > [1] https://gitlab.freedesktop.org/drm/intel/-/issues/6433
> 
> Hi Matthew,
> 
> Isabella sent a while ago a patch to IGT adding KUnit compatibility to
> IGT [1], but there wasn't any feedback on the patch. I believe that soon
> she will resend the series in order to make all KUnit DRM tests run on IGT.
> 
> Any feedback on the patch is welcomed so that we can fix this issue as
> soon as possible.
> 
> [1] https://patchwork.freedesktop.org/patch/489985/
> 
> Best Regards,
> - Maíra Canal

Hi.

Instead of going back to using IGT for *unit* tests, it would be a better idea
to adjust the CI to just run the tests once at "build" time (just like e.g.
checkpatch).

We would then stop executing the same test multiple times on different machines
(note that both DRM selftests and i915 "mock" selftests are pure unit tests - in
other words, they don't need the hardware to be present), which would save some
(small) amount of machine-time that can be utilized to do something that
actually needs the hardware.

Plus there's no need to maintain the kunit-runner in IGT.
Note - we're currently going to lose "DMESG-WARN" detection if we go this route,
but this is something that can be improved on the kunit-side.

-Michał