linux-kernel - Re: mainline build failure due to b67fbebd4cf9 ("mmu_gather: Force tlb-flush VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wipavrPuNPqiZ_zMP8EdbLKnnTkFukVCWm8FmCTUth4gQ@mail.gmail.com>
Date:   Fri, 22 Jul 2022 09:27:54 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     "Sudip Mukherjee (Codethink)" <sudipm.mukherjee@...il.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Will Deacon <will@...nel.org>,
        "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Nick Piggin <npiggin@...il.com>, Arnd Bergmann <arnd@...db.de>,
        linux-arch <linux-arch@...r.kernel.org>,
        Linux-MM <linux-mm@...ck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: mainline build failure due to b67fbebd4cf9 ("mmu_gather: Force
 tlb-flush VM_PFNMAP vmas")

On Fri, Jul 22, 2022 at 12:53 AM Sudip Mukherjee (Codethink)
<sudipm.mukherjee@...il.com> wrote:
>
> The latest mainline kernel branch fails to build for alpha allmodconfig
> with the error:

Gaah. It's the odd MMU_GATHER_NO_RANGE architectures - alpha, m68k,
microblaze, nios2 and openrisc.

We should probably get rid of that oddity, and force everybody to have
the ranged tlb flush functions, but for now the trivial patch is to
just remove the left-over dummy tlb_update_vma_flags() from that case,
I think.

Trivial patch attached. I don't have any cross-compiler for those
architectures on my machine, but I suspect I'll just commit it as-is
even without testing, since it can't be worse than what the situation
is right now with that "redefinition of 'tlb_update_vma_flags'"

But if you can verify, that would be lovely.

                    Linus

View attachment "patch.diff" of type "text/x-patch" (504 bytes)