linux-kernel - [PATCH v2] irqchip: mips-gic: check the return value of ioremap() in gic_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220723100128.2964304-1-williamsukatube@163.com>
Date:   Sat, 23 Jul 2022 18:01:28 +0800
From:   williamsukatube@....com
To:     tglx@...utronix.de, maz@...nel.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     tsbogend@...ha.franken.de, fancer.lancer@...il.com,
        William Dean <williamsukatube@....com>,
        Hacash Robot <hacashRobot@...tino.com>
Subject: [PATCH v2] irqchip: mips-gic: check the return value of ioremap() in gic_of_init()

From: William Dean <williamsukatube@....com>

The function ioremap() in gic_of_init() can fail, so
its return value should be checked.

Reported-by: Hacash Robot <hacashRobot@...tino.com>
Signed-off-by: William Dean <williamsukatube@....com>
---
v2: delete fixes tag and correct SoB tag

 drivers/irqchip/irq-mips-gic.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
index ff89b36267dd..a1f6d955794a 100644
--- a/drivers/irqchip/irq-mips-gic.c
+++ b/drivers/irqchip/irq-mips-gic.c
@@ -734,6 +734,10 @@ static int __init gic_of_init(struct device_node *node,
 	}
 
 	mips_gic_base = ioremap(gic_base, gic_len);
+	if (!mips_gic_base) {
+		pr_err("Failed to ioremap gic_base\n");
+		return -ENOMEM;
+	}
 
 	gicconfig = read_gic_config();
 	gic_shared_intrs = FIELD_GET(GIC_CONFIG_NUMINTERRUPTS, gicconfig);
-- 
2.25.1