linux-kernel - [irqchip: irq/irqchip-next] irqchip/mips-gic: Check the return value of ioremap() in gic_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <165866041980.15455.8736055814592911853.tip-bot2@tip-bot2>
Date:   Sun, 24 Jul 2022 11:00:19 -0000
From:   "irqchip-bot for William Dean" <tip-bot2@...utronix.de>
To:     linux-kernel@...r.kernel.org
Cc:     Hacash Robot <hacashRobot@...tino.com>,
        William Dean <williamsukatube@....com>,
        Marc Zyngier <maz@...nel.org>, tglx@...utronix.de
Subject: [irqchip: irq/irqchip-next] irqchip/mips-gic: Check the return value
 of ioremap() in gic_of_init()

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID:     71349cc85e5930dce78ed87084dee098eba24b59
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/71349cc85e5930dce78ed87084dee098eba24b59
Author:        William Dean <williamsukatube@....com>
AuthorDate:    Sat, 23 Jul 2022 18:01:28 +08:00
Committer:     Marc Zyngier <maz@...nel.org>
CommitterDate: Sun, 24 Jul 2022 10:54:44 +01:00

irqchip/mips-gic: Check the return value of ioremap() in gic_of_init()

The function ioremap() in gic_of_init() can fail, so
its return value should be checked.

Reported-by: Hacash Robot <hacashRobot@...tino.com>
Signed-off-by: William Dean <williamsukatube@....com>
Signed-off-by: Marc Zyngier <maz@...nel.org>
Link: https://lore.kernel.org/r/20220723100128.2964304-1-williamsukatube@163.com
---
 drivers/irqchip/irq-mips-gic.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
index ff89b36..a1f6d95 100644
--- a/drivers/irqchip/irq-mips-gic.c
+++ b/drivers/irqchip/irq-mips-gic.c
@@ -734,6 +734,10 @@ static int __init gic_of_init(struct device_node *node,
 	}
 
 	mips_gic_base = ioremap(gic_base, gic_len);
+	if (!mips_gic_base) {
+		pr_err("Failed to ioremap gic_base\n");
+		return -ENOMEM;
+	}
 
 	gicconfig = read_gic_config();
 	gic_shared_intrs = FIELD_GET(GIC_CONFIG_NUMINTERRUPTS, gicconfig);