linux-kernel - Re: [PATCH] hfsplus: Fix code typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e24fa505-3472-61c2-68ff-c728c5f10717@skogtun.org>
Date:   Sun, 24 Jul 2022 12:48:18 +0200
From:   Harald Arnesen <harald@...gtun.org>
To:     Matthew Wilcox <willy@...radead.org>, Xin Gao <gaoxin@...rlc.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hfsplus: Fix code typo


Matthew Wilcox [22/07/2022 23.32]:

> On Sat, Jul 23, 2022 at 03:51:33AM +0800, Xin Gao wrote:
>> The double `free' is duplicated in line 498, remove one.
> 
> This is wrong.  The intended meaning here is "trying to free bnode
> which is already free".  Please don't send patches for code you don't
> understand.

Perhaps inserting an "a" in the message would make it clearer?
(pr_crit("trying to free a free bnode ")
-- 
Hilsen Harald