linux-kernel - Re: [PATCH] keys/keyctl: Use kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1822bac5c28.17c2e13a236951.2030393349322231875@siddh.me>
Date:   Sat, 23 Jul 2022 20:58:12 +0530
From:   Siddh Raman Pant <code@...dh.me>
To:     "Greg KH" <gregkh@...uxfoundation.org>
Cc:     "David Howells" <dhowells@...hat.com>,
        "Jarkko Sakkinen" <jarkko@...nel.org>,
        "James Morris" <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        "linux-security-modules" <linux-security-module@...r.kernel.org>,
        "keyrings" <keyrings@...r.kernel.org>,
        "linux-kernel-mentees" 
        <linux-kernel-mentees@...ts.linuxfoundation.org>,
        "linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] keys/keyctl: Use kfree_rcu instead of kfree

On Sat, 23 Jul 2022 20:13:11 +0530  Greg KH <gregkh@...uxfoundation.org> wrote:
> You need to explain all of this in a changelog text.  Don't say what you
> do, but say why you are doing it.

Okay, I will keep this in mind next time.

> > > And how was this tested?
> > 
> > It compiles locally for me, and I used syzbot on this along with testing the
> > other `watch_queue_clear` patch, which generated no errors.
> 
> How does the watch queue stuff relate to this keyctl logic?
> 
> Again, be specific as to why you are doing things.

It doesn't relate, I just wanted to say that syzbot didn't crash too (I had
this change in the same branch as that patch for testing, and syzbot compiled
it successfully).

Sorry for the confusion.

Though now as James has pointed out, this patch isn't needed.

Apologies,
Siddh