linux-kernel - Re: [PATCH] keys/keyctl: Use kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1822bac680f.53b862f8236953.7679004564726067655@siddh.me>
Date:   Sat, 23 Jul 2022 20:58:15 +0530
From:   Siddh Raman Pant <code@...dh.me>
To:     "James Bottomley" <James.Bottomley@...senPartnership.com>
Cc:     "Greg KH" <gregkh@...uxfoundation.org>,
        "David Howells" <dhowells@...hat.com>,
        "Jarkko Sakkinen" <jarkko@...nel.org>,
        "James Morris" <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        "linux-security-modules" <linux-security-module@...r.kernel.org>,
        "keyrings" <keyrings@...r.kernel.org>,
        "linux-kernel-mentees" 
        <linux-kernel-mentees@...ts.linuxfoundation.org>,
        "linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] keys/keyctl: Use kfree_rcu instead of kfree

On Sat, 23 Jul 2022 20:20:49 +0530  James Bottomley <James.Bottomley@...senPartnership.com> wrote:
> That doesn't apply in this case, does it?  watch and wlist are locally
> allocated and neither has been made externally visible if the error leg
> is taken, so they should just be locally freed, which is what the code
> was doing before this proposed patch.

You are correct.

Sorry for this, I should have looked at it for a tad bit more.

Thanks,
Siddh