linux-kernel - Re: [PATCH RESEND 08/10] drm/v3d: use idr_init_base() to initialize v3d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220723224500.w6pezv3ojgu2d6qi@mail.igalia.com>
Date:   Sat, 23 Jul 2022 21:45:00 -0100
From:   Melissa Wen <mwen@...lia.com>
To:     Danilo Krummrich <dakr@...hat.com>
Cc:     airlied@...ux.ie, daniel@...ll.ch, mripard@...nel.org,
        christian.koenig@....com, emma@...olt.net,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH RESEND 08/10] drm/v3d: use idr_init_base() to initialize
 v3d_priv->perfmon.idr

On 07/20, Danilo Krummrich wrote:
> idr_init_base(), implemented by commit 6ce711f27500 ("idr: Make 1-based
> IDRs more efficient"), let us set an arbitrary base other than
> idr_init(), which uses base 0.
> 
> Since, for this IDR, no ID < 1 is ever requested/allocated, using
> idr_init_base(&idr, 1) avoids unnecessary tree walks.
> 
> Signed-off-by: Danilo Krummrich <dakr@...hat.com>
> Acked-by: Christian König <christian.koenig@....com>
> ---
>  drivers/gpu/drm/v3d/v3d_perfmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/v3d/v3d_perfmon.c b/drivers/gpu/drm/v3d/v3d_perfmon.c
> index f6a88abccc7d..48aaaa972c49 100644
> --- a/drivers/gpu/drm/v3d/v3d_perfmon.c
> +++ b/drivers/gpu/drm/v3d/v3d_perfmon.c
> @@ -95,7 +95,7 @@ struct v3d_perfmon *v3d_perfmon_find(struct v3d_file_priv *v3d_priv, int id)
>  void v3d_perfmon_open_file(struct v3d_file_priv *v3d_priv)
>  {
>  	mutex_init(&v3d_priv->perfmon.lock);
> -	idr_init(&v3d_priv->perfmon.idr);
> +	idr_init_base(&v3d_priv->perfmon.idr, 1);

Reviewed-by: Melissa Wen <mwen@...lia.com>

Thanks

>  }
>  
>  static int v3d_perfmon_idr_del(int id, void *elem, void *data)
> -- 
> 2.36.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)