linux-kernel - Re: [PATCH v1 17/33] thermal/drivers/rcar: Switch to new of API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yt5yjAAT3y4YSgl1@oden.dyn.berto.se>
Date:   Mon, 25 Jul 2022 12:38:04 +0200
From:   Niklas Söderlund 
        <niklas.soderlund@...natech.se>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Daniel Lezcano <daniel.lezcano@...exp.org>, rafael@...nel.org,
        rui.zhang@...el.com, khilman@...libre.com, abailon@...libre.com,
        amitk@...nel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org,
        "open list:RENESAS R-CAR THERMAL DRIVERS" 
        <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH v1 17/33] thermal/drivers/rcar: Switch to new of API

Hi Daniel,

On 2022-07-25 12:00:30 +0200, Daniel Lezcano wrote:
> 
> Hi Niklas,
> 
> On 25/07/2022 01:28, Niklas Söderlund wrote:
> > Hi (again) Daniel,
> > 
> > I figured it out, the thermal zone is disabled after this change. For
> > both rcar sensors with the new API thermal_zone_device_enable() is never
> > called.
> > 
> > In the old API the zone is enabled in the call chain of
> > devm_thermal_zone_of_sensor_register(). While after this change the zone
> > is not enabled by the core when calling thermal_zone_device_enable().
> > 
> > If I add a call to thermal_zone_device_enable() together with the new
> > API everything works as before. But I'm not sure if the correct solution
> > is to add a call to thermal_zone_device_enable() in the sensor drivers
> > or in the call chain of the new API?
> > 
> > On 2022-07-25 00:39:10 +0200, Niklas Söderlund wrote:
> > > Hi Daniel,
> > > 
> > > I tested your branch, unfortunately with the same result for
> > > rcar_gen3_thermal. Manipulation of emul_temp file do not trigger
> > > actions.
> 
> Thanks for investigating, I updated the branch. Does it fix the issue ?

I tested the branch with the head [1] and it restores the expected 
operation for both rcar_gen3_thermal and rcar_thermal sensors.

Thanks for the fix, with this change I'm happy with this new API.

1. commit e9b792a531c10756 ("thermal/of: Remove old OF code")

-- 
Kind Regards,
Niklas Söderlund