linux-kernel - Re: [PATCH 0/7] USB: cdc: add control and state defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5964CFE8-1B65-4FE2-9154-0F1C079CE916@bupt.edu.cn>
Date:   Mon, 25 Jul 2022 22:38:42 +0800
From:   Yan Xinyu <sdlyyxy@...t.edu.cn>
To:     Johan Hovold <johan@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Oliver Neukum <oneukum@...e.com>,
        Felipe Balbi <balbi@...nel.org>, linux-staging@...ts.linux.dev,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] USB: cdc: add control and state defines

> On Jul 25, 2022, at 15:58, Johan Hovold <johan@...nel.org> wrote:
> 
> Several drivers use the control-line and serial-state bitmap values from
> the CDC spec, but there were no matching defines in the global CDC
> (UAPI) header.
> 
> This series adds the missing defines and converts cdc-acm and f_acm to
> use them.
> 
> One staging driver also had an unused set of CDC defines which are
> removed.
> 
> The final patch by Yan Xinyu, which triggered this work, converts the
> usb_wwan driver to use CDC defines instead of hardcoded values in its
> line-control handling.
> 
> Greg, are you ok with me taking these through USB serial (where there
> are a few more drivers that could potentially use them) or do you want
> to take the lot through your tree directly?
> 
> Johan
> 
> 
> Johan Hovold (6):
>  USB: cdc: add control-signal defines
>  USB: cdc: add serial-state defines
>  USB: cdc-acm: use CDC control-line defines
>  USB: cdc-acm: use CDC serial-state defines
>  staging: gdm724x: drop unused CDC defines
>  USB: gadget: f_acm: use CDC defines
> 
> Yan Xinyu (1):
>  USB: serial: usb_wwan: replace DTR/RTS magic numbers with macros
> 
> drivers/staging/gdm724x/gdm_tty.c   |  6 -----
> drivers/usb/class/cdc-acm.c         | 42 ++++++++++++++---------------
> drivers/usb/class/cdc-acm.h         | 20 --------------
> drivers/usb/gadget/function/f_acm.c | 20 ++++----------
> drivers/usb/serial/usb_wwan.c       | 10 ++++---
> include/uapi/linux/usb/cdc.h        | 13 +++++++++
> 6 files changed, 45 insertions(+), 66 deletions(-)
> 
> -- 
> 2.35.1
> 

Thank you so much for spending your time to write this patch series!
And thank you and Greg for your reviews, they are very informative
and educational!

sdlyyxy