linux-kernel - Re: [net-next v2 3/3] dt-bindings: net: adin1110: Add docs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yt70avEl443NkbJq@lunn.ch>
Date:   Mon, 25 Jul 2022 21:52:10 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     alexandru.tachici@...log.com, netdev@...r.kernel.org,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        devicetree@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org,
        gerhard@...leder-embedded.com, geert+renesas@...der.be,
        joel@....id.au, stefan.wahren@...e.com, wellslutw@...il.com,
        geert@...ux-m68k.org, robh+dt@...nel.org,
        d.michailidis@...gible.com, stephen@...workplumber.org,
        l.stelmach@...sung.com, linux-kernel@...r.kernel.org
Subject: Re: [net-next v2 3/3] dt-bindings: net: adin1110: Add docs

> You had phy nodes here, but they were not replaced with the phy-handle.
> No ethernet-ports or mdios with phy?

Since this is integrated silicon, much of that is not required. There
is a fixed relationship between the MAC and the PHY, so phy-handle is
pointless. There is no need to describe the MDIO bus, because nothing
can change.  phy-mode is pointless, since it can only be internal.

ethernet-ports might be useful, if you want to use two different MAC
addresses. However, with Ethernet switches, you generally use the same
MAC address on all ports.

So i don't see a need for any of these properties.

   Andrew