linux-kernel - Re: [PATCH v2] docs: Fix typo in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d146f3d6-9b2a-5b54-4ae3-733047ef210e@infradead.org>
Date:   Mon, 25 Jul 2022 12:52:22 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     William Breathitt Gray <william.gray@...aro.org>,
        Joe Perches <joe@...ches.com>
Cc:     Baoquan He <bhe@...hat.com>, Jonathan Corbet <corbet@....net>,
        Slark Xiao <slark_xiao@....com>, kafai <kafai@...com>,
        vgoyal <vgoyal@...hat.com>, dyoung <dyoung@...hat.com>,
        ast <ast@...nel.org>, daniel <daniel@...earbox.net>,
        andrii <andrii@...nel.org>, "martin.lau" <martin.lau@...ux.dev>,
        song <song@...nel.org>, yhs <yhs@...com>,
        "john.fastabend" <john.fastabend@...il.com>,
        kpsingh <kpsingh@...nel.org>, sdf <sdf@...gle.com>,
        haoluo <haoluo@...gle.com>, jolsa <jolsa@...nel.org>,
        dhowells <dhowells@...hat.com>, peterz <peterz@...radead.org>,
        mingo <mingo@...hat.com>, will <will@...nel.org>,
        longman <longman@...hat.com>,
        "boqun.feng" <boqun.feng@...il.com>, tglx <tglx@...utronix.de>,
        bigeasy <bigeasy@...utronix.de>,
        kexec <kexec@...ts.infradead.org>,
        linux-doc <linux-doc@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>,
        linux-cachefs <linux-cachefs@...hat.com>
Subject: Re: [PATCH v2] docs: Fix typo in comment



On 7/25/22 06:57, William Breathitt Gray wrote:
> On Mon, Jul 25, 2022 at 06:52:15AM -0700, Joe Perches wrote:
>> On Fri, 2022-07-22 at 07:45 +0800, Baoquan He wrote:
>>> On 07/21/22 at 11:40am, Randy Dunlap wrote:
>>>> On 7/21/22 11:36, Jonathan Corbet wrote:
>>>>> "Slark Xiao" <slark_xiao@....com> writes:
>>>>>> May I know the maintainer of one subsystem could merge the changes
>>>>>> contains lots of subsystem?  I also know this could be filtered by
>>>>>> grep and sed command, but that patch would have dozens of maintainers
>>>>>> and reviewers.
>>>>>
>>>>> Certainly I don't think I can merge a patch touching 166 files across
>>>>> the tree.  This will need to be broken down by subsystem, and you may
>>>>> well find that there are some maintainers who don't want to deal with
>>>>> this type of minor fix.
>>>>
>>>> We have also seen cases where "the the" should be replaced by "then the"
>>>> or some other pair of words, so some of these changes could fall into
>>>> that category.
>>>
>>> It's possible. I searched in Documentation and went through each place,
>>> seems no typo of "then the". Below patch should clean up all the 'the the'
>>> typo under Documentation.
>> []
>>> The fix is done with below command:
>>> sed -i "s/the the /the /g" `git grep -l "the the " Documentation`
>>
>> This command misses entries at EOL:
>>
>> Documentation/trace/histogram.rst:  Here's an example where we use a compound key composed of the the
>>
>> Perhaps a better conversion would be 's/\bthe the\b/the/g'
> 
> It would be good to check for instances that cross newlines as well;
> i.e. "the" at the end of a line followed by "the" at the start of the
> next line. However, this would require some thought to properly account
> for comment blocks ("*") and other similar prefixes that should be
> ignored.

Yeah, the script that I posted last year (?) does that, but it's noisy --
results need to be hand-checked.

It's not clear how people are finding these repeated words, other than
something like
$ grep "the the" *


-- 
~Randy