linux-kernel - Re: [PATCH 2/2] pinctrl: amd: Use unicode for debugfs output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ+2XCSJo336+=k_fxmPxu=M3KZJofKfY5JqPXGoKmnYw@mail.gmail.com>
Date:   Tue, 26 Jul 2022 10:02:22 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     Basavaraj Natikar <Basavaraj.Natikar@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: amd: Use unicode for debugfs output

On Sat, Jul 23, 2022 at 12:08 AM Mario Limonciello
<mario.limonciello@....com> wrote:

> The output is currently split across two lines making it more
> difficult to parse unless the newlines are removed between pins
> or it's read in by a parser like Libreoffice Calc or Google docs.
>
> To make it easier to follow to the naked eye in a terminal window:
> * drop the newline in the middle of pin definitions
> * shorten all output using unicode characters
> * align all pipe delimitters
> * output the same phrase even for disabled functions
>   (but with a ∅ character)
>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

That's a bit unorthodox, what happens when someone uses their
old VT100 terminal to look at this file?

BIUT! It is a debugfs file, and you folks at AMD are going to be
using this and I just assume that you folks have aligned internally
that this is how you want things so I just applied this.

We need testing in linux-next for this anyway, the merge window
is close. If the other AMD people don't like it for some reason
I can always pull it out.

Yours,
Linus Walleij