linux-kernel - RE: [PATCH 2/2] pinctrl: amd: Use unicode for debugfs output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN0PR12MB6101B99C602809ACD6AB8839E2949@MN0PR12MB6101.namprd12.prod.outlook.com>
Date:   Tue, 26 Jul 2022 13:27:47 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@....com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     "Natikar, Basavaraj" <Basavaraj.Natikar@....com>,
        "S-k, Shyam-sundar" <Shyam-sundar.S-k@....com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] pinctrl: amd: Use unicode for debugfs output

[Public]

> -----Original Message-----
> From: Linus Walleij <linus.walleij@...aro.org>
> Sent: Tuesday, July 26, 2022 03:02
> To: Limonciello, Mario <Mario.Limonciello@....com>
> Cc: Natikar, Basavaraj <Basavaraj.Natikar@....com>; S-k, Shyam-sundar
> <Shyam-sundar.S-k@....com>; linux-gpio@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH 2/2] pinctrl: amd: Use unicode for debugfs output
> 
> On Sat, Jul 23, 2022 at 12:08 AM Mario Limonciello
> <mario.limonciello@....com> wrote:
> 
> > The output is currently split across two lines making it more
> > difficult to parse unless the newlines are removed between pins
> > or it's read in by a parser like Libreoffice Calc or Google docs.
> >
> > To make it easier to follow to the naked eye in a terminal window:
> > * drop the newline in the middle of pin definitions
> > * shorten all output using unicode characters
> > * align all pipe delimitters
> > * output the same phrase even for disabled functions
> >   (but with a ∅ character)
> >
> > Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> 
> That's a bit unorthodox, what happens when someone uses their
> old VT100 terminal to look at this file?

I guess it would look pretty terrible, but given it's debugfs very
unlikely.

> 
> BIUT! It is a debugfs file, and you folks at AMD are going to be
> using this and I just assume that you folks have aligned internally
> that this is how you want things so I just applied this.
> 
> We need testing in linux-next for this anyway, the merge window
> is close. If the other AMD people don't like it for some reason
> I can always pull it out.
> 

I didn't pre-align this with the other AMD guys.  It was just something
I noticed that has annoyed me as I look at bugs that I'm looking at and
since it's not sensitive content figured public review is fine for it.

That's why I left them on To: line.  But yes as you say if others don't like
it reverts are cheap and it's better to have enough time for good testing
coverage.

Thanks!