linux-kernel - Re: [PATCH 1/5] LoongArch: Add section of GOT for kernel module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fac4319d-26ee-1702-518c-2d6fbb1a0d57@loongson.cn>
Date:   Thu, 28 Jul 2022 17:21:05 +0800
From:   Youling Tang <tangyouling@...ngson.cn>
To:     Xi Ruoyao <xry111@...111.site>, loongarch@...ts.linux.dev
Cc:     linux-kernel@...r.kernel.org, WANG Xuerui <kernel@...0n.name>,
        Huacai Chen <chenhuacai@...nel.org>
Subject: Re: [PATCH 1/5] LoongArch: Add section of GOT for kernel module



On 07/28/2022 05:02 PM, Xi Ruoyao wrote:
> On Thu, 2022-07-28 at 16:29 +0800, Youling Tang wrote:
>> On 07/28/2022 12:26 AM, Xi Ruoyao wrote:
>>> +	mod->arch.got.shdr->sh_type = SHT_NOBITS;
>>> +	mod->arch.got.shdr->sh_flags = SHF_ALLOC;
>>> +	mod->arch.got.shdr->sh_addralign = L1_CACHE_BYTES;
>>> +	mod->arch.got.shdr->sh_size = (num_plts + 1) *
>>> sizeof(struct plt_entry);
>>> +	mod->arch.got.num_entries = 0;
>>> +	mod->arch.got.max_entries = num_plts;
>>  Hi, Ruoyao
>>
>>   We should use num_gots instead of num_plts when creating .got
>> section.
>
> Yes, it's a stupid error and I'll fix it in V2.
>
> But why didn't this cause a malfunction on my system? :(.

Maybe num_plts is greater than num_gots, and the size of plt_entry is 
equivalent to the size of four got_entry, so that when the module is 
loaded, it just allocates a larger space without causing the module to 
fail to load.

Thanks,
Youling
>