linux-kernel - Re: [PATCH 4/5] LoongArch: Stop using undocumented assembler options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f4ced23-2046-586c-2590-542923025149@loongson.cn>
Date:   Thu, 28 Jul 2022 17:46:39 +0800
From:   Youling Tang <tangyouling@...ngson.cn>
To:     Xi Ruoyao <xry111@...111.site>, loongarch@...ts.linux.dev
Cc:     linux-kernel@...r.kernel.org, WANG Xuerui <kernel@...0n.name>,
        Huacai Chen <chenhuacai@...nel.org>
Subject: Re: [PATCH 4/5] LoongArch: Stop using undocumented assembler options


On 07/28/2022 12:29 AM, Xi Ruoyao wrote:
> Now we can handle GOT and GOT-based relocations properly, remove the
> undocumented `-Wa,-mla-{global,local}-with-{pcrel,abs}` assembler hacks.
>
> Adjust assembly code to explicitly use "la.pcrel" where necessary.
>
> Signed-off-by: Xi Ruoyao <xry111@...111.site>
> ---
>  arch/loongarch/Makefile      |  5 +----
>  arch/loongarch/kernel/head.S | 10 +++++-----
>  2 files changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/arch/loongarch/Makefile b/arch/loongarch/Makefile
> index 039dcc4fe1f3..9552c7880d34 100644
> --- a/arch/loongarch/Makefile
> +++ b/arch/loongarch/Makefile
> @@ -40,10 +40,7 @@ endif
>
>  cflags-y			+= -G0 -pipe -msoft-float
>  LDFLAGS_vmlinux			+= -G0 -static -n -nostdlib
> -KBUILD_AFLAGS_KERNEL		+= -Wa,-mla-global-with-pcrel
> -KBUILD_CFLAGS_KERNEL		+= -Wa,-mla-global-with-pcrel
> -KBUILD_AFLAGS_MODULE		+= -Wa,-mla-global-with-abs
> -KBUILD_CFLAGS_MODULE		+= -fplt -Wa,-mla-global-with-abs,-mla-local-with-abs
> +KBUILD_CFLAGS_MODULE		+= -fplt

The -fplt flag may be removed, the compiler defaults to -fplt if not
specified (riscv is also not manually specified as -fplt).

Thanks,
Youling