[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <66e15d42-96fd-5b02-b7c8-a284d3f8d21f@linaro.org>
Date: Thu, 28 Jul 2022 13:51:37 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Shinjo Park <peremen@...il.com>
Cc: David Heidelberg <david@...t.cz>, Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: qcom: msm8960: add reference to sleep_clk
On 28/07/2022 13:16, Shinjo Park wrote:
> Change the reference of sleep_clk to the same as qcom-apq8064.dtsi.
You add label, not change something.
>
> Signed-off-by: Shinjo Park <peremen@...il.com>
> Reviewed-by: David Heidelberg <david@...t.cz>
> ---
> arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
> index e8cd1c9c0..991eb1948 100644
> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
> @@ -71,7 +71,7 @@ pxo_board: pxo_board {
> clock-output-names = "pxo_board";
> };
>
> - sleep_clk {
> + sleep_clk: sleep_clk {
Since you touch the line, make the device node sleep-clk (device node
names should not have underscores) and mention this in commit msg.
Best regards,
Krzysztof
Powered by blists - more mailing lists