[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f932415d-3bee-0948-a016-a2e837dd7256@linaro.org>
Date: Fri, 29 Jul 2022 14:33:02 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Shinjo Park <peremen@...il.com>
Cc: David Heidelberg <david@...t.cz>, Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: qcom: msm8960: add reference to sleep_clk
On 28/07/2022 14:51, Krzysztof Kozlowski wrote:
> On 28/07/2022 13:16, Shinjo Park wrote:
>> Change the reference of sleep_clk to the same as qcom-apq8064.dtsi.
>
> You add label, not change something.
>
>>
>> Signed-off-by: Shinjo Park <peremen@...il.com>
>> Reviewed-by: David Heidelberg <david@...t.cz>
>> ---
>> arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
>> index e8cd1c9c0..991eb1948 100644
>> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi
>> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
>> @@ -71,7 +71,7 @@ pxo_board: pxo_board {
>> clock-output-names = "pxo_board";
>> };
>>
>> - sleep_clk {
>> + sleep_clk: sleep_clk {
>
> Since you touch the line, make the device node sleep-clk (device node
> names should not have underscores) and mention this in commit msg.
Then we are back to the compat issues, since the gcc expects the
'sleep_clk' clock.
--
With best wishes
Dmitry
Powered by blists - more mailing lists