[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YuKbpXVOeGn2l2gd@sirena.org.uk>
Date: Thu, 28 Jul 2022 15:22:29 +0100
From: Mark Brown <broonie@...nel.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
Cc: agross@...nel.org, bjorn.andersson@...aro.org, lgirdwood@...il.com,
robh+dt@...nel.org, quic_plai@...cinc.com, bgoswami@...cinc.com,
perex@...ex.cz, tiwai@...e.com, srinivas.kandagatla@...aro.org,
quic_rohkumar@...cinc.com, linux-arm-msm@...r.kernel.org,
alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
swboyd@...omium.org, judyhsiao@...omium.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: qcom: SC7280: Add support for external DMIC
bias supply
On Thu, Jul 28, 2022 at 07:29:49PM +0530, Srinivasa Rao Mandadapu wrote:
> Update SC7280 machine driver for enabling external dmic bias supply,
> which is required for villager evt boards.
> +++ b/sound/soc/qcom/sc7280.c
> @@ -356,6 +356,7 @@ static const struct snd_soc_ops sc7280_ops = {
> static const struct snd_soc_dapm_widget sc7280_snd_widgets[] = {
> SND_SOC_DAPM_HP("Headphone Jack", NULL),
> SND_SOC_DAPM_MIC("Headset Mic", NULL),
> + SND_SOC_DAPM_REGULATOR_SUPPLY("DMICVDD", 0, 0),
> };
>
> static int sc7280_snd_platform_probe(struct platform_device *pdev)
Don't you want to connect this to something? This won't do anything
as-is. I can't see any references to DMICVDD which might be failing to
resolve in the current sound/soc/qcom.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists