linux-kernel - Re: [PATCH v2] ASoC: qcom: SC7280: Add support for external DMIC bias supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a92891b1-1fd0-82fa-3dc4-34282e6c2ef3@quicinc.com>
Date:   Thu, 28 Jul 2022 21:39:55 +0530
From:   Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
To:     Mark Brown <broonie@...nel.org>
CC:     <agross@...nel.org>, <bjorn.andersson@...aro.org>,
        <lgirdwood@...il.com>, <robh+dt@...nel.org>,
        <quic_plai@...cinc.com>, <bgoswami@...cinc.com>, <perex@...ex.cz>,
        <tiwai@...e.com>, <srinivas.kandagatla@...aro.org>,
        <quic_rohkumar@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        <swboyd@...omium.org>, <judyhsiao@...omium.org>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2] ASoC: qcom: SC7280: Add support for external DMIC bias
 supply


On 7/28/2022 7:52 PM, Mark Brown wrote:
Thanks for your time Mark!!!
> On Thu, Jul 28, 2022 at 07:29:49PM +0530, Srinivasa Rao Mandadapu wrote:
>> Update SC7280 machine driver for enabling external dmic bias supply,
>> which is required for villager evt boards.
>> +++ b/sound/soc/qcom/sc7280.c
>> @@ -356,6 +356,7 @@ static const struct snd_soc_ops sc7280_ops = {
>>   static const struct snd_soc_dapm_widget sc7280_snd_widgets[] = {
>>   	SND_SOC_DAPM_HP("Headphone Jack", NULL),
>>   	SND_SOC_DAPM_MIC("Headset Mic", NULL),
>> +	SND_SOC_DAPM_REGULATOR_SUPPLY("DMICVDD", 0, 0),
>>   };
>>   
>>   static int sc7280_snd_platform_probe(struct platform_device *pdev)
> Don't you want to connect this to something?  This won't do anything
> as-is.  I can't see any references to DMICVDD which might be failing to
> resolve in the current sound/soc/qcom.

The connection is being done to "VA DMIC"through audio routing in board 
specific dts file.

Will post the changes once the main dts patches are landed.

Ex:-

&sound {
     DMICVDD-supply = <&pp1800_l2c>;

     audio-routing =
             "IN1_HPHL", "HPHL_OUT",
             "IN2_HPHR", "HPHR_OUT",
             "AMIC1", "MIC BIAS1",
             "AMIC2", "MIC BIAS2",
             "VA DMIC0", "DMICVDD",
             "VA DMIC1", "DMICVDD",
             "VA DMIC2", "DMICVDD",
             "VA DMIC3", "DMICVDD",
             .....

             .....

};