linux-kernel - Re: [PATCH v2] kvm: mmu: fix typos in struct kvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YuK2ci/LJ2BTHqah@google.com>
Date:   Thu, 28 Jul 2022 09:16:50 -0700
From:   David Matlack <dmatlack@...gle.com>
To:     Hao Peng <flyingpenghao@...il.com>
Cc:     pbonzini@...hat.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Sean Christopherson <seanjc@...gle.com>
Subject: Re: [PATCH v2] kvm: mmu: fix typos in struct kvm_arch

On Thu, Jul 28, 2022 at 06:37:24PM +0800, Hao Peng wrote:
> From: Peng Hao <flyingpeng@...cent.com>
> 
> No 'kvmp_mmu_pages', it should be 'kvm_mmu_page'. And
> struct kvm_mmu_pages and struct kvm_mmu_page are different structures,
> here should be kvm_mmu_page.
> kvm_mmu_pages is defined in arch/x86/kvm/mmu/mmu.c.
> 
> Suggested-by: David Matlack <dmatlack@...gle.com>
> Signed-off-by: Peng Hao <flyingpeng@...cent.com>

Reviewed-by: David Matlack <dmatlack@...gle.com>

> ---
>  arch/x86/include/asm/kvm_host.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index e8281d64a431..e67b2f602fb2 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1272,8 +1272,8 @@ struct kvm_arch {
>         bool tdp_mmu_enabled;
> 
>         /*
> -        * List of struct kvm_mmu_pages being used as roots.
> -        * All struct kvm_mmu_pages in the list should have
> +        * List of kvm_mmu_page structs being used as roots.
> +        * All kvm_mmu_page structs in the list should have
>          * tdp_mmu_page set.
>          *
>          * For reads, this list is protected by:
> @@ -1292,8 +1292,8 @@ struct kvm_arch {
>         struct list_head tdp_mmu_roots;
> 
>         /*
> -        * List of struct kvmp_mmu_pages not being used as roots.
> -        * All struct kvm_mmu_pages in the list should have
> +        * List of kvm_mmu_page structs not being used as roots.
> +        * All kvm_mmu_page structs in the list should have
>          * tdp_mmu_page set and a tdp_mmu_root_count of 0.
>          */
>         struct list_head tdp_mmu_pages;
> @@ -1303,9 +1303,9 @@ struct kvm_arch {
>          * is held in read mode:
>          *  - tdp_mmu_roots (above)
>          *  - tdp_mmu_pages (above)
> -        *  - the link field of struct kvm_mmu_pages used by the TDP MMU
> +        *  - the link field of kvm_mmu_page structs used by the TDP MMU
>          *  - lpage_disallowed_mmu_pages
> -        *  - the lpage_disallowed_link field of struct kvm_mmu_pages used
> +        *  - the lpage_disallowed_link field of kvm_mmu_page structs used
>          *    by the TDP MMU
>          * It is acceptable, but not necessary, to acquire this lock when
>          * the thread holds the MMU lock in write mode.
> --
> 2.27.0