linux-kernel - Re: [PATCH v2] perf parse-events: Break out tracepoint and printing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 29 Jul 2022 07:39:14 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Jiri Olsa <olsajiri@...il.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v2] perf parse-events: Break out tracepoint and printing.

On Fri, Jul 29, 2022 at 4:44 AM Jiri Olsa <olsajiri@...il.com> wrote:
>
> On Thu, Jul 07, 2022 at 12:12:09PM -0700, Ian Rogers wrote:
> > Move print_*_events functions out of parse-events.c into a new
> > print-events.c. Move tracepoint code into tracepoint.c or
> > trace-event-info.c (sole user). This reduces the dependencies of
>
> it seems like it'd be better to have those changes in separated
> patches, at least for review

Agreed. I'll follow up with a v3.

Thanks,
Ian

> jirka
>
> > parse-events.c and makes it more amenable to being a library in the
> > future.
> > Remove some unnecessary definitions from parse-events.h. Fix a
> > checkpatch.pl warning on using unsigned rather than unsigned int.
> > Fix some line length warnings too.
> >
> > v2. Rebase in particular after hybrid PMU changes.
> >
> > Signed-off-by: Ian Rogers <irogers@...gle.com>
>
> SNIP