linux-kernel - [PATCH] RDMA/rxe: Correct error handling in routines allocating xarray entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon,  1 Aug 2022 01:38:50 -0600
From:   William Kucharski <william.kucharski@...cle.com>
To:     Zhu Yanjun <zyjzyj2000@...il.com>, Jason Gunthorpe <jgg@...pe.ca>,
        Leon Romanovsky <leon@...nel.org>, rpearsonhpe@...il.com,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     William Kucharski <william.kucharski@...cle.com>
Subject: [PATCH] RDMA/rxe: Correct error handling in routines allocating xarray entries

The current code will report an error if xa_alloc_cyclic() returns
non-zero, but it will return 1 if it wrapped indices before successfully
allocating an entry.

An error should only be reported if the call actually failed (denoted by
a return value < 0.)

Fixes: 3225717f6dfa2 ("RDMA/rxe: Replace red-black trees by xarrays")
Signed-off-by: William Kucharski <william.kucharski@...cle.com>
---
 drivers/infiniband/sw/rxe/rxe_pool.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_pool.c b/drivers/infiniband/sw/rxe/rxe_pool.c
index 19b14826385b..e9f3bbd8d605 100644
--- a/drivers/infiniband/sw/rxe/rxe_pool.c
+++ b/drivers/infiniband/sw/rxe/rxe_pool.c
@@ -139,7 +139,7 @@ void *rxe_alloc(struct rxe_pool *pool)
 
 	err = xa_alloc_cyclic(&pool->xa, &elem->index, elem, pool->limit,
 			      &pool->next, GFP_KERNEL);
-	if (err)
+	if (err < 0)
 		goto err_free;
 
 	return obj;
@@ -167,7 +167,7 @@ int __rxe_add_to_pool(struct rxe_pool *pool, struct rxe_pool_elem *elem)
 
 	err = xa_alloc_cyclic(&pool->xa, &elem->index, elem, pool->limit,
 			      &pool->next, GFP_KERNEL);
-	if (err)
+	if (err < 0)
 		goto err_cnt;
 
 	return 0;
-- 
2.37.1